Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README file has incorrect descriptions for configuration options #38

Closed
visto9259 opened this issue Feb 17, 2023 · 0 comments · Fixed by #86
Closed

README file has incorrect descriptions for configuration options #38

visto9259 opened this issue Feb 17, 2023 · 0 comments · Fixed by #86
Labels
documentation Improvements or additions to documentation V3 To be fixed in version 3

Comments

@visto9259
Copy link
Member

visto9259 commented Feb 17, 2023 •
edited
Loading

The description of the configuration options in the README.md file is incorrect. What the README file states as the default is not consistent with the comments in the config/lmcuser.global.php.dist file.

For example, it states that use_registration_form_captcha is true by default but it is false be default.

We need some scrubbing of this file to line it with default module options in src/Options/ModuleOptions.php and at the same time, make sure the comments in config/lmcuser.global.php.dist are also aligned.
@visto9259 visto9259 added the documentation Improvements or additions to documentation label Feb 17, 2023
@visto9259 visto9259 added the V3 To be fixed in version 3 label Apr 17, 2024
visto9259 added a commit to visto9259/LmcUser that referenced this issue Jun 26, 2024
@visto9259
To fix LM-Commons#38
9457e9b 
Signed-off-by: Eric Richer eric.richer@vistoconsulting.com <eric.richer@vistoconsulting.com>
@visto9259 visto9259 mentioned this issue Jun 26, 2024
Merged
visto9259 added a commit that referenced this issue Jun 26, 2024
@visto9259
Merge pull request #86 from visto9259/fix_38
7fa19f1 
To fix #38
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in LmcUser Development Jun 26, 2024
visto9259 added a commit to visto9259/LmcUser that referenced this issue Jun 26, 2024
@visto9259
To fix LM-Commons#38
33e1ed1 
Signed-off-by: Eric Richer eric.richer@vistoconsulting.com <eric.richer@vistoconsulting.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation V3 To be fixed in version 3
Projects
LmcUser Development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

To fix #38 visto9259/LmcUser
1 participant
@visto9259