Remove unittest2, return to unittest #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently using a custom-modified unittest2, which itself was a modified version of the standard library package unittest. Originally, unittest2 allowed people to use later versions of unittest in early 2.* versions of python. It also backported certain utilities from python's 3.4 version of unittest back to python2. We don't use python2 anymore. We don't need unittest2 anymore. This commit removes all unittest2 and removes the custom unittest2 dependency.
|
As additional background, I'll note that I was experiencing a testing heisenbug that sometimes affected me (and the CI on my fork). I talked about this with David Roe and Edgar, but it felt really mysterious. This doesn't solve that heisenbug. |
|
Fine with me. |
|
should we add also, given that you touched, I would consider removing |
|
Yes, I think removing |
|
We don't need to add |
As advocated by Edgar and David Roe at LMFDB#6062
|
This is likely going to fail the CMF tests as well, but if that is all that fails I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using a custom-modified unittest2, which itself was a modified version of the standard library package unittest.
Originally, unittest2 allowed people to use later versions of unittest in early 2.* versions of python. It also backported certain utilities from python's 3.4 version of unittest back to python2.
We don't use python2 anymore. We don't need unittest2 anymore. This commit removes all unittest2 and removes the custom unittest2 dependency.