Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Priority for FadeButton #1932

Closed
tresf opened this issue Apr 6, 2015 · 0 comments
Closed

Incorrect Priority for FadeButton #1932

tresf opened this issue Apr 6, 2015 · 0 comments
Assignees
@curlymorphic
Labels
bug core
Milestone
1.2.0

Comments

@tresf
Copy link
Member

tresf commented Apr 6, 2015

The decision was made to NOT use Signals/Slots in favor of a proper fix, unless we didn't get one in time for the release of 1.2.

Since we're nearing a 1.2 feature freeze, I wanted to make a placeholder.

Per conversation in #1600 (comment)

Offending line: FadeButton->activate() on or around InstrumentTrack.cpp#L389 committed in 1e25b91.

image
@tresf tresf added the bug label Apr 6, 2015
@tresf tresf added this to the 1.2.0 milestone Apr 6, 2015
@Umcaruje Umcaruje added the core label Jul 5, 2015
@curlymorphic curlymorphic self-assigned this Jul 19, 2015
@curlymorphic curlymorphic mentioned this issue Jul 19, 2015
Merged
@tresf tresf mentioned this issue Aug 24, 2015
Closed
ThomasJClark pushed a commit to ThomasJClark/lmms that referenced this issue Sep 12, 2015
@curlymorphic @ThomasJClark
Revert Correct Priorty of fade button
37f4515 
reverted changes made in  LMMS#1527
copied from Github diff

Fixes LMMS#1932
@tresf tresf mentioned this issue Oct 11, 2017
Open
@tresf tresf mentioned this issue Jan 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curlymorphic curlymorphic

Labels
bug core
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@Umcaruje @tresf @curlymorphic