-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion / feature request] sf3 player #3286
Comments
@trebmuh thanks for the bug report. This is really a |
@tresf : thanks for the pointer; really appreciated. It sounds great. Just to be 100% sure of my understanding, can you confirm/infirm the following: LMMS is using fluidsynth for the sf2 management. So, if/when the support for sf3 is added to fluidsynth, then LMMS will be able to deal with the sf3 soundfonts. Am I right here? Going further, if I'm able to manage to build a local fluidsynth with the patch from sourceforge, would that mean that LMMS will be able to deal with sf3 straight, or would LMMS need to be rebuild as well to do so? |
Yes. We may have to add the
If your changes are published LMMS could technically point to your source instead. This isn't necessarily a quick task. See this thread for a similar situation: #3224 (comment) Probably the best way to get this in is to get upstream to accept it and then it will naturally flow down stream. |
That sounds great.
I'm not planning to fork it. I'm planning to building a (debian) package with the patch included. If it works fine, then I could try to push it to Debian official repo. Unfortunately, it does look to me that fluidsynth has stopped its development back in 2015 (if we are to believe the git master https://sourceforge.net/p/fluidsynth/code-git/ci/f52597be038a5a045fc74b6f96d5f9b0bbbbc044/log/?path= ). When I'll have some time to do so, I'll fill the bug report on sourceforge to report my experience, and will enjoy this time to check if fluidsynth is still active (I hope it is and I missed something!). |
@trebmuh yes they have three merge requests (for newcomers, this is the Sourceforge equivalent of a Pull Request) dating back to two years ago. Assuming the authors are permanently absent, a more fruitful task would be to cherry-pick and coordinate with the various forks and bring the library back into life with official support on github. You could manage it under LMMS repo if you wish and just use the PR HACK method to get admins to take it over. Edit: |
@tresf : re-reading this thread, I'm wondering if fluidsynth is bundled in LMMS or if LMMS is linked to it as an external library. Can you please enlighten me here? |
@trebmuh although we do bundle some of our plugins (such as all of the LADSPA plugins), sf2 is purely external currently. Please see https://github.com/LMMS/lmms/tree/master/plugins/sf2_player. This means long term LMMS as a whole (all platforms) will suffer the same problem you've described by having no upstream maintainer. A new collaborative home is dire at this point. 😕 |
New upstream issue here: FluidSynth/fluidsynth#140 |
This has now been implemented upstream: FluidSynth/fluidsynth#183 |
awesome ! |
After a quick look into the LMMS sources, I can't find any mention to sf3. Has that been done and I'm not looking at the right place ? |
No, reopening. |
OK, thanks. I'll wait patiently for something to test. Please let me know if I can be of any help then. |
Ah, I missed this part.
Yes indeed. Can you find a couple of sf3 files to try out? |
@zonkmachine : there is one shipped with Musescore that you can find here in the debian packaging repo: https://anonscm.debian.org/cgit/pkg-multimedia/musescore.git/tree/share/sound?id=8958f57f5e8b7dc59fec77941ba6f9efc9eb38cf |
Here's a downloadable file: (the Debian archive loads in a binary view) https://github.com/musescore/MuseScore/blob/master/share/sound/FluidR3Mono_GM.sf3?raw=true |
PR available for testing here: #3895 |
Nice. Talk to you at #3895 . |
Closed via #3895. |
Sorry to post this on this old issue but I don't really understand. Why aren't sf3 format supported now? (version 1.2.2) if they are supported could it be more clear how to do it? I only see a SF2 player. I don't see any SF3. And it simply not work when I try to import it. I downloaded the file from Musescore's website. |
@chopin2712 quoting tresf, emphasis mine
|
Quick note: LMMS 1.2.2 from LibraZiK-3 here. I can load a SF3 file and play with it with the LMMS "Sf2 player" module because LMMS is patched to support SF3. |
The SF3 format has been invented by the lead developer of Musescore and is implemented in Musescore (http://musescore.org/) and Polyphone (http://polyphone-soundfonts.com/).
The SF3 format is the same than the SF2 one but the samples are in OGG and not in WAV. This in order to allow the soundfonts file weight to be heavily reduced.
It'd be great to have this support in LMMS (if that's not already the case and I missed it).
The text was updated successfully, but these errors were encountered: