-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated all the songs to current version #2813
Conversation
The templates?: |
I had the folder completely empty, I don't know |
Because of #2525 |
OK. Anyway, will look them too |
Yes.
I think it's better to just treat the templates like the rest of the projects. |
I added them
(to open them, go to the Open Project browser, to their folder, and type their name and extension.) |
Looks good but it has conflicts ( #2809 ) and needs rebasing against latest master. |
Yea now it does. |
Rebase. I did that when I tested it so I know it'll rebase just fine. |
I see some of the project files are uncompressed. Maybe we should ship all the demos and templates as compressed? |
I thought about that. |
Yup, seems it worked, rebased, force-pushed, and here they are. |
@DeRobyJ I'm sorry to burden you with this, but I fear the track versions should read If you don't have the ability to create a build with |
I just have to add the "FORCE_VERSION: 1.2.0" or something like that? |
@DeRobyJ if you're compiling from source, it's part of the Configuring 1.1.90-g9c5cbbe
--------------------------
* Build version : 1.1.90-g9c5cbbe
* Major version : 1
* Minor version : 1
* Patch version : 90
* Suffix version : g9c5cbbe
*
Optional Version Usage:
--------------------------
+* Override version: -DFORCE_VERSION=x.x.x-x
* Disable hash suffix: -DFORCE_VERSION=internal and then you run cmake .. -DFORCE_VERSION=1.2.0 # plus whatever else you put on command line and you should get something like this on the console: Configuring 1.2.0
--------------------------
+* Build version : 1.2.0
* Major version : 1
* Minor version : 2
* Patch version : 0
* Suffix version :
*
Optional Version Usage:
--------------------------
* Override version: -DFORCE_VERSION=x.x.x-x
* Disable hash suffix: -DFORCE_VERSION=internal |
Ok, I'll try in the next days, right now I can't spend much time re-saving all the projects, but I'll do it! |
Good job @DeRobyJ 👍 |
There's some crashing going on...
Same with ExoXLB-CPU About the shorties/DirtyLove project, when loading it AFTER having loaded another project, lmms hangs. Other than that, I updated the projects to a forced 1.2.0 version. |
@DeRobyJ, I cannot reproduce the crashes and hang. Do they happen in master branch? Are the updated projects the cause? |
I was in master (actually on my branch, but only projects differ) and I get the same problem in the qt5 build for windows on some projects. Can't investigate much right now |
All projects load and play first 5 seconds fine. I have listened to these ones completely:
|
|
Thanks for testing. Project cleaning and sample recovery should be addressed in a new issue/pr. |
Perhaps projects have been upgraded too soon. If there is a new |
Doesn't the version mismatch window only appear if the version number is different? |
Yes, @jasp00's point:
The only item that comes to mind currently is #2742 |
Updated all the songs to current version
General info:
I gave a look at all the projects, listed here by folder.
Each project I re-saved, I also re-ordered a bit, to show the editors where things are happening.
I wrote "order was made" on projects that were kinda chaotic (e.g. multiple maximized windows)
What's left?
I did not filter projects for quality, but I suggest to discuss some of them in the future.
Fixes #2812