Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all the songs to current version #2813

Merged
merged 3 commits into from
Jul 16, 2016
Merged

Updated all the songs to current version #2813

merged 3 commits into from
Jul 16, 2016

Conversation

DeRobyJ
Copy link
Contributor

@DeRobyJ DeRobyJ commented Jun 1, 2016

General info:

I gave a look at all the projects, listed here by folder.
Each project I re-saved, I also re-ordered a bit, to show the editors where things are happening.
I wrote "order was made" on projects that were kinda chaotic (e.g. multiple maximized windows)

What's left?

  • Replace missing samples and effects, if possible contacting the authors
  • Update Automations blocks made of stairs to the new "vectorial" ones
  • Delete Greshz-CoolS., as written in the list log
  • Create new project or remix some of the simple ones to show new features

I did not filter projects for quality, but I suggest to discuss some of them in the future.

Fixes #2812


list log

"Demos" folder:
"CapDan" subfolder:
RaggaeTry:  removed unused mixer channels
        re-saved

RaggaetonTry:   removed unused mixer channels
        re-saved

TwilinghtAre.:  removed unused mixer channels
        re-saved

ZeroSumGame.:   removed unused mixer channels
        re-saved


"Skiessi" subfolder:
C64:        removed mixer channels (weren't used)
        resaved

Onion:      removed unused mixer channels
        re-saved
        (there are some clicks due to the volume env on bitdefender, they seem to be intended tho)

RandomProjec.:  removed unused mixer channels
        Turned up master gain to 95% (was too low with no reason, even if it's "designed for cheap headphones)
        re-saved

TurningPoint:   removed unused mixer channels
        re-saved


"Zakarra" subfolder:
59_Degrees: MISSING SAMPLES
        fixed clicks on "sub bass" instrument (vol env. was opened but not tweaked, like he did in the next song on "low bass")
        Song loop points added and activated (music doesn't "end", but can be repeated)
        removed unused mixer channels
        re-saved

MainstreamMe.:  MISSING SAMPLES
        order was made
        (there is some distortion, but no problem to me)
        removed unused mixer channels
        re-saved

OneDay:     MISSING SAMPLES
        Moved song to beginning of Song Editor (Shift+Canc)
        Moved loop point so it loops well, but de-activated because of intro. User has to activate it once passed the point.
        removed unused mixer channels
        re-saved


.. no subfolder
Alf42red-Mau.:  removed unused mixer channels
        re-saved

AngryLlama-N.:  removed unused mixer channels (none used, it's a lb302 "dead" button demo)
        re-saved

Ashore:     removed unused mixer channels
        re-saved

DnB:        removed unused mixer channels
        re-saved

EsoXLB-CPU: removed unused mixer channels
        re-saved

Farbro-Tecto.:  removed unused mixer channels
        re-saved

Greippi - Kr.:  removed unused mixer channels
        re-saved (just for the channels, the project is in fact recent)

Impulslogik-.:  removed unused mixer channels
        re-saved

Momo64-esp: Translated automation block name to English (was in Italian)
        removed unused mixer channels (none used)
        re-saved

Namitryus-K-.:  removed unused mixer channels (none used)
        re-saved
        (Some things are in French, no big deal to me)

Oglsdl-Dr8v2:   removed unused mixer channels
        re-saved

Oglsdl-PpTrip:  removed unused mixer channels
        re-saved

Popsip-Elect.:  Updated links to lsp in project notes
        removed unused mixer channels
        re-saved

Root84-Initi.:  removed unused mixer channels (none used)
        re-saved

Saber-FinalS.:  removed unused mixer channels
        re-saved

Settel-Inner.:  removed unused mixer channels
        re-saved

Shovon-Progr.:  Removed unused samples (they were also missing)
        Tried to fix the peak controlled side chain
        removed unused mixer channels
        re-saved


Socceroos-Pr.:  removed unused mixer channels (none used)
        re-saved

StrictProduc.:  removed unused default 3osc track
        removed unused mixer channels (none used)
        re-saved

TameAnderson.:  removed unused default 3osc track and unused last zyn track
        removed unused mixer channels
        re-saved

Thaledric-Ar.:  MISSING EFFECTS
        removed unused mixer channels (none used)
        re-saved
        (this one is really distorted)

Thomasso-Axe.:  removed unused mixer channels
        fixed some clipping
        re-saved

TobyDox-Psyc.:  removed unused mixer channels (none used)
        re-saved

unfa-Spoken:    MISSING SAMPLE spoken.flac
        removed unused mixer channels (none used)
        re-saved



_____________________________________

"Shorties" folder:

Crunk(Demo):    removed unused mixer channels
        re-saved

Dirty Love: nothing here

Greshz-CoolS.:  Project is too empty
        Delete

Root84-Tranc.:  removed unused mixer channels (none used)
        re-saved

Skiessi-222:    removed unused mixer channels (none used)
        re-saved

Surrender-Ma.:  removed unused mixer channels
        re-saved

sv-DnB-Start.:  removed unused mixer channels
        re-saved

sv-Trance-St.:  removed unused mixer channels
        re-saved



_____________________________________

"Tutorials" folder:
editing_note.:  order was made
        re-saved


@zonkmachine
Copy link
Member

What's left?

The templates?:
https://github.com/LMMS/lmms/tree/master/data/projects/Templates

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 1, 2016

I had the folder completely empty, I don't know

@zonkmachine
Copy link
Member

I had the folder completely empty

Because of #2525

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 1, 2016

OK.
Do they need to be re-saved too?
I actually think we shouldn't show the version warning for templates.

Anyway, will look them too

@zonkmachine
Copy link
Member

Do they need to be re-saved too?

Yes.

I actually think we shouldn't show the version warning for templates.

I think it's better to just treat the templates like the rest of the projects.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 2, 2016

I added them

"Templates" folder:
AcousticDrum.:  re-saved

ClubMix:    re-saved

CR8000:     removed unused mixer channels
        re-saved

Empty:      no warning shown, nothing to do here

TR808:      removed unused mixer channels
        re-saved

(to open them, go to the Open Project browser, to their folder, and type their name and extension.)

@zonkmachine
Copy link
Member

Looks good but it has conflicts ( #2809 ) and needs rebasing against latest master.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 4, 2016

Yea now it does.
Not sure if it's better to manually re-do the renaming on my local copy or to rebase it with git commands

@zonkmachine
Copy link
Member

Not sure if it's better to manually re-do the renaming on my local copy or to rebase it with git commands

Rebase. I did that when I tested it so I know it'll rebase just fine.

@zonkmachine
Copy link
Member

I see some of the project files are uncompressed. Maybe we should ship all the demos and templates as compressed?

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 5, 2016

I thought about that.
I think we should have an example of everything.
It doesn't change much, but it may change for some, rare, cases.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jun 6, 2016

Yup, seems it worked, rebased, force-pushed, and here they are.

@tresf
Copy link
Member

tresf commented Jul 5, 2016

@DeRobyJ I'm sorry to burden you with this, but I fear the track versions should read creatorversion="1.2.0" rather than creatorversion="1.1.90-g9c5cbbe" which would require the re-saving of these with a build that has FORCE_VERSION applied to the build process.

If you don't have the ability to create a build with 1.2.0 in the version information, let us know and we can create one for you.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 5, 2016

I just have to add the "FORCE_VERSION: 1.2.0" or something like that?

@tresf
Copy link
Member

tresf commented Jul 5, 2016

@DeRobyJ if you're compiling from source, it's part of the cmake command.

 Configuring 1.1.90-g9c5cbbe
 --------------------------
 * Build version               : 1.1.90-g9c5cbbe
 *   Major version             : 1
 *   Minor version             : 1
 *   Patch version             : 90
 *   Suffix version            : g9c5cbbe
 *
 Optional Version Usage:
 --------------------------
+*   Override version:           -DFORCE_VERSION=x.x.x-x
 *   Disable hash suffix:        -DFORCE_VERSION=internal

and then you run

cmake .. -DFORCE_VERSION=1.2.0 #  plus whatever else you put on command line

and you should get something like this on the console:

 Configuring 1.2.0
 --------------------------
+* Build version               : 1.2.0
 *   Major version             : 1
 *   Minor version             : 2
 *   Patch version             : 0
 *   Suffix version            : 
 *
 Optional Version Usage:
 --------------------------
 *   Override version:           -DFORCE_VERSION=x.x.x-x
 *   Disable hash suffix:        -DFORCE_VERSION=internal

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 5, 2016

Ok, I'll try in the next days, right now I can't spend much time re-saving all the projects, but I'll do it!

@Umcaruje
Copy link
Member

Good job @DeRobyJ 👍

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 10, 2016

There's some crashing going on...

  • Open Zankarra - One Day
  • Then open any other project, or create a new project
    /crash

Same with ExoXLB-CPU

About the shorties/DirtyLove project, when loading it AFTER having loaded another project, lmms hangs.
However if you load it from blank, it works fine.
You can also load a project, create a new project, and then load DirtyLove, and the programs works fine.

Other than that, I updated the projects to a forced 1.2.0 version.
I also saved/updated files that I didn't edit before, like the "Empty" template and a project i suggested to delete, but 'till then, it's now updated to 1.2.0

@jasp00
Copy link
Member

jasp00 commented Jul 10, 2016

@DeRobyJ, I cannot reproduce the crashes and hang. Do they happen in master branch? Are the updated projects the cause?

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 11, 2016

I was in master (actually on my branch, but only projects differ) and I get the same problem in the qt5 build for windows on some projects.
Seems like something that comes up in prpjects saved under 1.1.90

Can't investigate much right now

@jasp00
Copy link
Member

jasp00 commented Jul 16, 2016

All projects load and play first 5 seconds fine. I have listened to these ones completely:

Alf42red-Mauiwowi.mmpz
CapDan-ZeroSumGame-OriginalByZakarra.mmpz
Crunk(Demo).mmp
Impulslogik-Zen.mmpz
Settel-InnerRecreation.mmpz

unfa-Spoken.mmpz uses too many resources on my machine. The projects with missing samples should probably be fixed.
Merging...

@jasp00 jasp00 merged commit 67ce400 into LMMS:master Jul 16, 2016
@jasp00
Copy link
Member

jasp00 commented Jul 16, 2016

Greshz-CoolSnip.mmpz is still present.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 16, 2016

Thanks for testing.

Project cleaning and sample recovery should be addressed in a new issue/pr.
unfa-Spoken does play well on a recent machine..

@jasp00
Copy link
Member

jasp00 commented Jul 17, 2016

Perhaps projects have been upgraded too soon. If there is a new upgrade_ function, all projects will need to be re-saved.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Jul 17, 2016

Doesn't the version mismatch window only appear if the version number is different?

@tresf
Copy link
Member

tresf commented Jul 17, 2016

Doesn't the version mismatch window only appear if the version number is different?

Yes, @jasp00's point:

  • If a 1.1 track uses an unwritten or unmerged feature/component which an upgrade_foo() needs to be written, we've now re-saved as a 1.2 track without performing said upgrade.

The only item that comes to mind currently is #2742

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Updated all the songs to current version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants