Complete overall avoids touching RSpec innards #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def warn_about_promotion(scope_name) | ||
| RSpec::Steps.warnings[ | ||
| "#{scope_name} :each blocks declared for steps are always treated as " + |
There was a problem hiding this comment.
Readme seems to suggest before :step has gone away, but this message suggests otherwise. Which is correct?
There was a problem hiding this comment.
before :step used to have a particular and important meaning. You can still use it in your own code (mostly to reduce the degree to which we'd have to re-write steps code) but I discovered that e.g. waterpig cannot (because reasons.)
All that said: it's better not to use before :step and at some future time we might remove it entirely.
What do you think?
hannahhoward
added a commit
that referenced
this pull request
Sep 21, 2015
Complete overall avoids touching RSpec innards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible now with RSpec 3.0-3.3+, and forseeable versions of RSpec.
Experience with current code suggests that at worst we may have to update the
test suite for rspec-steps to keep it working