39851: New example file #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create SampleSet domain and fields to an existing SampleSet.
labkey-klum
reviewed
Mar 12, 2020
samples/sampleset_domain_example.py
Outdated
| # domain.create returns the full Domain definition | ||
| created_sampleset_domain = domain.create(server_context, sampleset_domain_definition) | ||
|
|
||
|
|
There was a problem hiding this comment.
remove this whitespace
labkey-klum
reviewed
Mar 12, 2020
samples/sampleset_domain_example.py
Outdated
| # Drop a domain | ||
| ################### | ||
|
|
||
| #drop_response = domain.drop(server_context, 'samples', 'BloodSamples') |
There was a problem hiding this comment.
I would either uncomment these lines or delete them entirely
labkey-klum
requested changes
Mar 12, 2020
|
@labkey-steveh Should probably look to get this merged soon as we have other changes we're currently adding and can roll this into the version bump. |
Changes suggested by Karl.
|
Thanks Karl, I made the changes you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create SampleSet domain and fields to an existing SampleSet. For issue #39851