Skip to content

Remove Python 2 Support #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 22, 2020
Merged

Remove Python 2 Support #42

merged 15 commits into from
Oct 22, 2020

Conversation

labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Oct 7, 2020 •
edited
Loading

Rationale

Python 2 is no longer supported, and has not been supported since January 2020

Related Pull Requests

  • n/a

Changes

  • container.create: rename folderType arg to folder_type, rename isWorkbook arg to is_workbook
  • Remove support for Python 2.x
  • Add Type annotations
    • We don't have 100% of our API methods typed yet, but we are getting there
  • Format code with Black (a static code formatter)
    • This is why the diff is so big. I am sorry, but it was necessary.
  • remove build_url helper
    • it was just a single line wrapper around server_context
  • remove create_server_context
    • It was just a wrapper around ServerContext, you can replace all usages of create_server_context with ServerContext
  • Add APIWrapper
    • This wraps all of the supported APIs so you don't need to pass around a server_context
  • Removed various "from_data" methods
    • They were all simple one line wrappers around Class constructors that were not needed

@labkey-alan labkey-alan self-assigned this Oct 7, 2020
@labkey-alan
Remove unsupported modules
da4f5c8
@labkey-alan
Update examples to use APIWrapper
7907943
@labkey-alan
Nits in domain.py
3d8bea5 
- Simplify some logic in conditional_format
- Improve type annotation for query_filter param
- Improve error message
- Use f-strings
@labkey-alan
Update README to use APIWrapper
0ef51f3
@labkey-alan labkey-alan merged commit 8601e72 into main Oct 22, 2020
@labkey-alan labkey-alan deleted the fb_py3 branch October 22, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-nicka labkey-nicka labkey-nicka approved these changes

Assignees

@labkey-alan labkey-alan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-alan @labkey-nicka