Skip to content

Fix issue 43337 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Fix issue 43337 #47

merged 2 commits into from
Jun 24, 2021

Conversation

labkey-alan
Copy link
Contributor

Rationale

The Python client throws an error if you attempt to create a domain from a template because you don't pass a domain definition with a "domainDesign". This PR does a None check for "domainDesign" before attempting to format conditional filters.

Related Pull Requests

  • n/a

Changes

  • Make "domainDesign" optional when calling domain.create (Fixes issue 43337)

@labkey-alan labkey-alan requested a review from labkey-nicka June 23, 2021 21:16
@labkey-alan labkey-alan self-assigned this Jun 23, 2021
@labkey-alan labkey-alan merged commit 7835d36 into develop Jun 24, 2021
@labkey-alan labkey-alan deleted the fb_fix_43337 branch June 24, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants