Skip to content

Fix issues 43337, 43611 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2021
Merged

Fix issues 43337, 43611 #48

merged 6 commits into from
Aug 11, 2021

Conversation

labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Jul 28, 2021 •
edited
Loading

Rationale

This PR fixes Issues 43337, 43611

Related Pull Requests

  • n/a

Changes

  • Add get_domain_details API to domain module
  • Fix Issue 43337
  • Fix ConditionalFormat.to_json to match what LabKey Server response
  • domain.save: support optional "options"

@labkey-alan labkey-alan requested a review from labkey-nicka July 28, 2021 18:03
@labkey-alan labkey-alan self-assigned this Jul 28, 2021
labkey-nicka
labkey-nicka reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@labkey-nicka labkey-nicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent a patch containing what we discussed regarding support for domainId.

@labkey-alan labkey-alan requested a review from labkey-nicka July 28, 2021 21:15
@labkey-alan labkey-alan merged commit f5bcd73 into develop Aug 11, 2021
@labkey-alan labkey-alan deleted the fb_issue_43611 branch August 11, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-nicka labkey-nicka labkey-nicka approved these changes

Assignees

@labkey-alan labkey-alan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-alan @labkey-nicka