Skip to content

Conversation

labkey-nicka
Copy link
Contributor

Rationale

This PR adds save_rows to the Query API. Accessible via api wrapper as api.query.save_rows.

Implementation note: This makes use of TypedDict to improve static type analysis for this API. TypedDict was made available starting in Python 3.8. We currently support Python 3.7+, however 3.7 was EOL back in October of 2024. To this end, I've updated our minimum required version to 3.10 which will EOL in October of 2026. Certainly willing to shift this depending on how disruptive this may or may not be to users. I've also updated the setup.py to specify python_requires=">=3.10" which will make our required version more clear to users and Python repositories. To make sure this doesn't catch anyone off-guard I've bumped the package version to 4.0.0.

Changes

  • Add endpoint wrapper for query-saveRows.api named save_rows()
  • Make endpoint accessible via API wrapper
  • Add integration and units tests
  • Specify python_requires in setup.py

@labkey-nicka labkey-nicka requested a review from labkey-alan July 8, 2025 00:37
@labkey-nicka labkey-nicka self-assigned this Jul 8, 2025
Copy link
Contributor

@labkey-alan labkey-alan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating the supported versions.

@labkey-nicka labkey-nicka merged commit caa481c into develop Jul 8, 2025
4 checks passed
@labkey-nicka labkey-nicka deleted the fb_save_rows_py branch July 8, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants