Skip to content

File path related issue bundle #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 5, 2025
Merged

File path related issue bundle #1833

merged 11 commits into from
Aug 5, 2025

Conversation

XingY
Copy link
Contributor

@XingY XingY commented Jul 15, 2025

Rationale

There are scenarios that the file is invalid but the triangle warning icon is not displayed. One scenario is when the file does exist on the file system, but the user lack permission to it or if it's of invalid access context from current folder. In those scenarios, we should show triangle warning icon.

Related Pull Requests

Changes

  • check both value and displayValue for unavailable file

XingY added 5 commits July 15, 2025 13:21
# Conflicts:
#	biologics/package-lock.json
#	biologics/package.json
#	inventory/package-lock.json
#	inventory/package.json
#	sampleManagement/package-lock.json
#	sampleManagement/package.json

Merge branch 'develop' into fb_filePathIssues

# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md
# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md
# Conflicts:
#	biologics/package-lock.json
#	biologics/package.json
#	inventory/package-lock.json
#	inventory/package.json
#	sampleManagement/package-lock.json
#	sampleManagement/package.json
XingY added 2 commits July 25, 2025 09:50
# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md
# Conflicts:
#	biologics/package-lock.json
#	biologics/package.json
#	inventory/package-lock.json
#	inventory/package.json
#	sampleManagement/package-lock.json
#	sampleManagement/package.json
#	sampleManagement/test/src/org/labkey/test/tests/samplemanagement/folders/SMProSamplesCrossFolderCRUDTest.java
# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md

Merge branch 'develop' into fb_filePathIssues

# Conflicts:
#	biologics/package-lock.json
#	biologics/package.json
#	biologics/test/src/org/labkey/test/tests/biologics/assay/BiologicsAssayFilesTest.java
#	inventory/package-lock.json
#	inventory/package.json
#	sampleManagement/package-lock.json
#	sampleManagement/package.json
#	sampleManagement/test/src/org/labkey/test/tests/samplemanagement/samples/SMSampleUpdateTest.java
@XingY XingY requested a review from labkey-susanh August 4, 2025 21:59
Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not done any testing of these changes.

XingY added 3 commits August 4, 2025 18:43
# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md
@XingY XingY merged commit f4f88fd into develop Aug 5, 2025
3 checks passed
@XingY XingY deleted the fb_filePathIssues branch August 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants