7109: Allow QC states to be set and updated via Python API #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

RosalineP merged 10 commits into develop from fb_qcUpdatesForAPI_7109

May 26, 2020

Contributor

RosalineP commented May 20, 2020

Rationale

To allow for QC State definitions and QC State assignments to be created, removed, and updated via Python API.

Changes

QCStateTableInfo is now writable via implementing a QueryUpdateService, rendering to table auto-accessible for API language bindings
Gates against deletion of in-use QC state definition through API

RosalineP added 4 commits

May 18, 2020 09:54


          Gates against API deletion of QC State Definition when the def is in …

c8fbdba

…use.


          Removes comments to self. Adds cache clearing in create case

1e87cdc


          Cleans up spacing

d6ab579


          Merge branch 'develop' into fb_qcUpdatesForAPI_7109

53e111f

RosalineP requested a review from labkey-klum

May 20, 2020 17:22

labkey-klum reviewed

View reviewed changes

api/src/org/labkey/api/qc/QCStateManager.java Outdated Show resolved Hide resolved

labkey-klum reviewed

View reviewed changes

core/src/org/labkey/core/CoreController.java Outdated Show resolved Hide resolved

labkey-klum reviewed

View reviewed changes

core/src/org/labkey/core/query/QCStateTableInfo.java Outdated Show resolved Hide resolved

labkey-klum reviewed

View reviewed changes

core/src/org/labkey/core/query/QCStateTableInfo.java Outdated Show resolved Hide resolved

labkey-klum reviewed

View reviewed changes

core/src/org/labkey/core/query/QCStateTableInfo.java Outdated Show resolved Hide resolved

labkey-klum approved these changes

View reviewed changes

Contributor

labkey-klum left a comment

overall looks good but please address comments.

RosalineP added 3 commits

May 20, 2020 16:36


          Apply feedback

504068c


          Tweak to application of feedback (adds commitTask)

df91d58


          Merge branch 'develop' into fb_qcUpdatesForAPI_7109

daf54b3

RosalineP mentioned this pull request

7109: Add QC state code examples LabKey/labkey-api-python#35

Merged

RosalineP added 3 commits

May 20, 2020 23:26


          Also must clear cache when updating

4837afd


          Fix some spacing

981da25


          Merge branch 'develop' into fb_qcUpdatesForAPI_7109

e7a5a5c

RosalineP merged commit 14bde6f into develop

RosalineP deleted the fb_qcUpdatesForAPI_7109 branch

May 26, 2020 17:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet