Fix creation of empty sequence on CertificatePolicies Extension #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when creating a Certificate which has the Certificate Policies extension but the included policy has no Policy Qualifier, the certificate is issued with an empty qualifiers sequence. According to RFC 5280 the policyQualifiers is an optional field, however if it exists it must be greater than zero, and thus the empty sequence would make the Certificate format invalid.
To fix this, before creating the policyQualifiers sequence, first it checks if said Policy has any qualifiers and only creates the sequence if it does.