Skip to content

[AL-5296] Add global key support to ConversationEntity, DocumentEntity, DicomSe… #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

[AL-5296] Add global key support to ConversationEntity, DocumentEntity, DicomSe… #1013

merged 1 commit into from
Mar 20, 2023

Conversation

kkim-labelbox
Copy link
Contributor

@kkim-labelbox kkim-labelbox commented Mar 20, 2023 •
edited
Loading

…gments

  • Added global key to serialization of ConversationEntity, DocumentEntity and DicomSegments
  • Rearranged conversation and pdf tests, and added global_key test cases to the 3 types above

@kkim-labelbox kkim-labelbox requested review from vbrodsky and whistler and removed request for vbrodsky March 20, 2023 21:42
whistler
whistler approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@whistler whistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkim-labelbox kkim-labelbox merged commit 51039b2 into develop Mar 20, 2023
@kkim-labelbox kkim-labelbox deleted the kkim/AL-5296 branch March 20, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrodsky vbrodsky Awaiting requested review from vbrodsky

1 more reviewer

@whistler whistler whistler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkim-labelbox @whistler