Skip to content

Conversation

rahullb
Copy link
Contributor

@rahullb rahullb commented Apr 24, 2023

adding subclassifications to ontologies

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rahullb rahullb requested a review from ovalle15 April 24, 2023 21:02
@@ -46,7 +46,41 @@
"!pip install labelbox"
Copy link
Contributor

@ovalle15 ovalle15 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add "-q" to prevent the printing of all the installations


Reply via ReviewNB

@@ -46,7 +46,41 @@
"!pip install labelbox"
Copy link
Contributor

@ovalle15 ovalle15 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove API key. I would also suggest deleting this key from your account


Reply via ReviewNB

@@ -46,7 +46,41 @@
"!pip install labelbox"
Copy link
Contributor

@ovalle15 ovalle15 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to include in the this PR the changes we introduce in 3.40.0 https://docs.labelbox.com/changelog/4-3-23

It is just a few lines, you could copy/paste from this branch - : https://github.com/Labelbox/labelbox-python/blob/ao_ontology_nb/examples/basics/ontologies.ipynb

This is out of scope but it would be great if we can include it.


Reply via ReviewNB

@@ -43,7 +43,7 @@
{
Copy link
Contributor

@ovalle15 ovalle15 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, could you please replace "instructions" with "name" since is the recommended way of doing it.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@rahullb rahullb merged commit e26f972 into develop Apr 27, 2023
@rahullb rahullb deleted the rahul-subclassification branch April 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants