[SDK-35] Improve mea tests #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/improve-mea-test_SDK-35
branch
from
8d90339 to
23813c7
Compare
vbrodsky
commented
Sep 20, 2023
| # TODO: Use a real URI | ||
| 'instanceURI': "sampleuri", | ||
| 'colorRGB': [0, 0, 0] | ||
| "instanceURI": |
There was a problem hiding this comment.
original mask was invalid for an image we use
vbrodsky
commented
Sep 20, 2023
| @@ -1016,6 +1015,17 @@ def object_predictions(polygon_inference, rectangle_inference, line_inference, | |||
| ] | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
There was a problem hiding this comment.
entity_inference not valid for an image
vbrodsky
commented
Sep 20, 2023
| @@ -11,22 +11,11 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| def test_create_from_url(model_run_with_data_rows, | |||
There was a problem hiding this comment.
duplicate test, see below
vbrodsky
force-pushed
the
VB/improve-mea-test_SDK-35
branch
from
23813c7 to
5b3110a
Compare
vbrodsky
force-pushed
the
VB/improve-mea-test_SDK-35
branch
from
5b3110a to
5049882
Compare
vbrodsky
force-pushed
the
VB/improve-mea-test_SDK-35
branch
from
3b8796d to
a66561a
Compare
vbrodsky
force-pushed
the
VB/improve-mea-test_SDK-35
branch
from
a66561a to
8c3f1b3
Compare
yamini-labelbox
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/SDK-35
Update mea upload tests to use valid annotations and add finer-grain error checking