-
Notifications
You must be signed in to change notification settings - Fork 68
Add global key support for Project move_data_rows_to_task_queue #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dec190
to
1d42a1b
Compare
vbrodsky
commented
Nov 15, 2023
kopreschko
reviewed
Nov 15, 2023
e328d24
to
4e9376f
Compare
kopreschko
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kopreschko
reviewed
Nov 17, 2023
29b53bb
to
9b7aa2d
Compare
LGTM, i'll wait on the engineers to give the final approval |
sqlboy
reviewed
Nov 20, 2023
sqlboy
reviewed
Nov 20, 2023
sqlboy
reviewed
Nov 21, 2023
48c7906
to
8d64de8
Compare
sqlboy
reviewed
Nov 27, 2023
f09b165
to
34fe8f3
Compare
sqlboy
approved these changes
Nov 27, 2023
569cee5
to
1e6a0fe
Compare
45a7fdc
to
d61b973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/SDK-414
API PR: https://github.com/Labelbox/intelligence/pull/18036
Identifiable
hierarchy to ensure a consistent approach in handling data row IDs and global keys.Identifiable
objects, we are utilizing the @overload decorator.