Skip to content

Add global key support for Project move_data_rows_to_task_queue #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 15, 2023

Story: https://labelbox.atlassian.net/browse/SDK-414
API PR: https://github.com/Labelbox/intelligence/pull/18036

  • We are implementing the Identifiable hierarchy to ensure a consistent approach in handling data row IDs and global keys.
  • To support both legacy string inputs and the new Identifiable objects, we are utilizing the @overload decorator.
  • Our plan is to apply this same methodology to other methods that require the management of both data row IDs and global keys.

@vbrodsky vbrodsky requested review from a team, kopreschko and kkim-labelbox November 15, 2023 22:18
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch 2 times, most recently from 7dec190 to 1d42a1b Compare November 15, 2023 22:22
@vbrodsky vbrodsky requested a review from a team November 16, 2023 17:53
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch 3 times, most recently from e328d24 to 4e9376f Compare November 17, 2023 21:49
Copy link
Contributor

@kopreschko kopreschko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrian-chang adrian-chang requested a review from a team November 18, 2023 04:42
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch 3 times, most recently from 29b53bb to 9b7aa2d Compare November 20, 2023 19:46
@adrian-chang
Copy link
Contributor

LGTM, i'll wait on the engineers to give the final approval

@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch from 48c7906 to 8d64de8 Compare November 21, 2023 18:16
@vbrodsky vbrodsky requested a review from sqlboy November 21, 2023 23:00
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch from f09b165 to 34fe8f3 Compare November 27, 2023 21:36
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch from 569cee5 to 1e6a0fe Compare November 28, 2023 18:26
@vbrodsky vbrodsky force-pushed the VB/move_data_rows_to_task_queue_gk-SDK-414 branch from 45a7fdc to d61b973 Compare November 28, 2023 23:58
@vbrodsky vbrodsky merged commit deac9c4 into develop Nov 29, 2023
@vbrodsky vbrodsky deleted the VB/move_data_rows_to_task_queue_gk-SDK-414 branch November 29, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants