Skip to content

Conversation

ramy1951
Copy link
Contributor

Updated notebooks to include support for bytes array for annotation import on masks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ramy1951 ramy1951 changed the title Added support for annotation import with img bytes [SN-107]Added support for annotation import with img bytes Jan 25, 2024
@ramy1951 ramy1951 requested a review from ovalle15 January 26, 2024 18:53
@ramy1951
Copy link
Contributor Author

Screenshot 2024-01-26 at 10 54 11 AM Here is the project I created using the notebook

@@ -1,18 +1,16 @@
{
Copy link
Contributor

@ovalle15 ovalle15 Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #33.          "dataRow": {

This shouldn't be place here


Reply via ReviewNB

@ovalle15
Copy link
Contributor

@ramy1951 thank you for taking a look, can you please use the format for all the other annotations and always run the notebooks with both python annotations and ndjson to verify your work. Thank you !

@ovalle15
Copy link
Contributor

@ramy1951 any chance we can get this merge today ?

@ramy1951
Copy link
Contributor Author

Addressed reviews, I tried the notebook after updates with all annotations. It works just fine

@ovalle15 ovalle15 merged commit c233986 into develop Jan 30, 2024
@ovalle15 ovalle15 deleted the maskBytes-notebook branch January 30, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants