Skip to content

V2.5.4 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Apr 22, 2021
Merged

V2.5.4 #140

merged 33 commits into from
Apr 22, 2021

Conversation

msokoloff1
Copy link
Contributor

No description provided.

Matt Sokoloff added 30 commits April 7, 2021 08:29
cursor pagination, basic queries
e90a528
mostly working
e1d1254
added doc strings, small changes
8451398
added missing tests and mypy
43edd75
bugs
072efbf
docs and yapf
ac3d84d
fixed test
0022d75
added example
83ee2b2
docstring
5b564eb
yapf
291f10a
update imports
f69361a
fix circular import
9f6655e
consistent query format
83a33fa
fix bug
132ffc6
update pagination, other small changes
10cf8de
beta wip
eac1c8d
try/finally beta
39e29d6
removed queries that aren't ready
215d73f
clean up
518c638
fix import bug
724b042
revert dockerfile
c6e092a
fix tests
a413f33
fixed test bug
c1029a4
thread safe
dfd6f3a
mypy pagination
b2e11e7
recommended changes
93012c5
recommended changes
e6e4dd6
fix cursor pagination bug
3276182
Fix example notebook and add to readme, make recommended changes
dd8f18b
recommended changes
0fbf8e1
@msokoloff1 msokoloff1 requested review from nmaswood and gszpak April 22, 2021 13:41
@msokoloff1
Copy link
Contributor Author

Depends on #139

nmaswood
nmaswood approved these changes Apr 22, 2021
View reviewed changes
Copy link

@nmaswood nmaswood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although create_data_rows(tiled=True) as I said on the last PR feels funny to me. Like what if we add one or more new features like tiled imagery are we going to keep needing to add boolean flags?

@msokoloff1 msokoloff1 merged commit 4c71f41 into develop Apr 22, 2021
@msokoloff1 msokoloff1 deleted the v2.5.4 branch April 22, 2021 19:48
msokoloff1 added a commit that referenced this pull request Sep 22, 2021
@msokoloff1
Merge pull request #140 from Labelbox/v2.5.4
7136ecc 
V2.5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gszpak gszpak gszpak approved these changes

@nmaswood nmaswood nmaswood approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msokoloff1 @gszpak @nmaswood