Skip to content

Conversation

msokoloff1
Copy link
Contributor

No description provided.

@msokoloff1 msokoloff1 requested a review from gdj0nes May 17, 2021 18:45
Comment on lines 184 to 186
download_url = res["downloadUrl"]
data = requests.get(download_url)
return ndjson.loads(data.text)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably could just be a single line

Copy link
Contributor Author

@msokoloff1 msokoloff1 May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it multiple lines so the errors would be more clear. Added raise_for_status() so that it actually serves that purpose..

@msokoloff1 msokoloff1 requested a review from gdj0nes May 17, 2021 18:57
@msokoloff1 msokoloff1 requested a review from nidoran May 17, 2021 20:04
@msokoloff1 msokoloff1 merged commit 4245636 into develop May 17, 2021
@msokoloff1 msokoloff1 deleted the ms/download-export branch May 17, 2021 20:14
msokoloff1 added a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants