Skip to content

Bump dateutil max version #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

colonelpanic8
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@colonelpanic8 colonelpanic8 requested a review from a team as a code owner July 8, 2024 02:08
@adrian-chang
Copy link
Contributor

Hey @colonelpanic8

So we use rye for development, not poetry so the PR as is won't be able to be approved.

Please read this for further details (https://github.com/Labelbox/labelbox-python/blob/develop/CONTRIBUTING.md).

We'll take care of the dateutil bump, but what is the need for a head version of OpenCV? We're not aware of any use case of the SDK needing a head version.

@colonelpanic8
Copy link
Contributor Author

@adrian-chang yeah sorry, i forgot i had made this pr and i was using this pr to mess around with a git build.

the original change was just a bump tho:

071b396

@colonelpanic8
Copy link
Contributor Author

I adjusted things so that my poetry stuff is in another branch.

@adrian-chang
Copy link
Contributor

I'm going to merge this in ... given a library bump, our GHActions will have to be updated to address remote forks, thanks though!

@adrian-chang adrian-chang merged commit da4fe9c into Labelbox:develop Jul 8, 2024
8 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants