Skip to content

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jan 15, 2025

Description

Pinterest are on v.3.78.1 and they can not switch to a higher version due to pydantic v1.

They have an issue exporting non-english chars (see below) that we have fixed in v.5.2.1

I am backporting this change

Before the export looked like
'value': 'décembre 2023',

In v.3.78.2 it id fixed:
'value': 'décembre 2023'

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner January 15, 2025 18:53
@vbrodsky vbrodsky merged commit 9b86233 into branch_v.3.78.2 Jan 15, 2025
3 checks passed
@vbrodsky vbrodsky deleted the VB/backport-export-charset_PLT-2336 branch January 15, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant