initial addition to include filters for export_labels #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing on the following error: on this test: This is causing other PR's to fail and also when I run locally. Unsure for RCA for why this keeps failing here... |
msokoloff1
reviewed
Feb 3, 2022
msokoloff1
reviewed
Feb 3, 2022
msokoloff1
reviewed
Feb 3, 2022
msokoloff1
reviewed
Feb 3, 2022
msokoloff1
reviewed
Feb 4, 2022
Comment on lines
+282
to
+287
| quote = "\"" if value_with_quotes else "" | ||
| return ",".join([ | ||
| f"""{c}: {quote}{dictionary.get(c)}{quote}""" | ||
| for c in dictionary | ||
| if dictionary.get(c) | ||
| ]) |
msokoloff1
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial phase is done, but there looks to be an issue with the filters themselves. Speaking with Utkarsh more on this before requesting a review