get_resource_tags and create_project_resource_tags #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
|
You need to install the pre-commit hooks to format the files (that is why the build is failing). Also you mind adding a couple of tests? Overall looks good! |
manibox
force-pushed
the
mani/resource-tags
branch
from
fad0ea7 to
09899b7
Compare
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
msokoloff1
reviewed
Feb 9, 2022
+1 let's have end to end tests here for each schema + change that assert both success cases and expected failure cases |
manibox
force-pushed
the
mani/resource-tags
branch
from
2bbcaac to
ef35913
Compare
manibox
force-pushed
the
mani/resource-tags
branch
2 times, most recently
from
6eba2a3 to
dd3f24f
Compare
manibox
force-pushed
the
mani/resource-tags
branch
3 times, most recently
from
f42102a to
a3fc815
Compare
manibox
force-pushed
the
mani/resource-tags
branch
from
a3fc815 to
90708e9
Compare
msokoloff1
reviewed
Feb 17, 2022
msokoloff1
reviewed
Feb 17, 2022
msokoloff1
reviewed
Feb 17, 2022
msokoloff1
reviewed
Feb 17, 2022
|
@jtsodapop could you take a look at this |
jtsodapop
reviewed
Feb 21, 2022
msokoloff1
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two calls to our SDK,
TDD: https://docs.google.com/document/d/1r60QC3Ch_zu3UPEEMVF9R0la4OQlelmQngfhIPMIPEo/edit#heading=h.ql1qz79ruc9v
Jira
https://labelbox.atlassian.net/jira/software/c/projects/ORCH/boards/52?modal=detail&selectedIssue=ORCH-835
Screen.Recording.2022-02-09.at.3.08.39.PM.mov