Skip to content

jtso/AL-677 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2022
Merged

jtso/AL-677 #436

merged 5 commits into from
Feb 14, 2022

Conversation

jtsodapop
Copy link
Contributor

…nput their API key

@jtsodapop jtsodapop requested a review from gdj0nes February 11, 2022 16:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@gdj0nes
Copy link

gdj0nes commented Feb 11, 2022

Lets remove the endpoint too. that can just be highlighted somewhere else

@jtsodapop
Copy link
Contributor Author

Lets remove the endpoint too. that can just be highlighted somewhere else

Updated to exclude it

@jtsodapop jtsodapop changed the title update to remove colab key request and instead just request user to i… jtso/AL-677 Feb 14, 2022
@jtsodapop
Copy link
Contributor Author

objectives:
standardize pip install
remove Google secret storage from all notebooks -> client = Client()
remove getpass

@jtsodapop jtsodapop requested a review from paulnoirel February 14, 2022 16:31
@jtsodapop jtsodapop merged commit 1d27b92 into develop Feb 14, 2022
@jtsodapop jtsodapop deleted the al-677-colab-key branch February 14, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaeljafriLB raphaeljafriLB Awaiting requested review from raphaeljafriLB

@paulnoirel paulnoirel Awaiting requested review from paulnoirel

1 more reviewer

@gdj0nes gdj0nes gdj0nes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtsodapop @gdj0nes