Skip to content

Conversation

farkob
Copy link
Contributor

@farkob farkob commented Apr 22, 2022

Adds

project.batches()

batch.export_data_rows() (depends on intelligence pr #8171)

Batch.project() fix

batch.remove_queued_data_rows()

@farkob farkob force-pushed the farkob/batch-features branch from 7b06216 to 7dee8ef Compare April 22, 2022 18:54
@@ -23,3 +32,45 @@ class Batch(DbObject):
# Relationships
project = Relationship.ToOne("Project")
created_by = Relationship.ToOne("User")

def export_data_rows(self, timeout_seconds=120) -> Generator:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the same output structure as dataset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@gdj0nes
Copy link

gdj0nes commented Apr 22, 2022

LGTM to me but @msokoloff1 should give final sign off

Comment on lines 858 to 863
cursor_path={
'project': None,
'batches': None,
'pageInfo': None,
'endCursor': None
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the type hint for PaginatedCollection is wrong. This can probably just be a list of the keys.

Copy link
Contributor Author

@farkob farkob Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looked wrong to me too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can also change the type hint from :
cursor_path: Optional[Dict[str, Any]] = None
to
cursor_path: Optional[List[str]] = None
That would be awesome

@@ -1,5 +1,14 @@
# Changelog

# Version 3.20.0 (2022-04-27)
## Added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is going to be a new version of the SDK, can we also include information on this merged PR?

#540

Updated

  • NDJsonConverter now supports Video bounding box annotations.
    • Note: Currently does not support nested classifications.
    • Note: Converting an export into Labelbox annotation types, and back to export will result in only keyframe annotations. This is to support correct import format.

cc @msokoloff1 if this wording looks okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup looks good. Thanks

@farkob farkob merged commit 5eff529 into develop Apr 27, 2022
@msokoloff1 msokoloff1 deleted the farkob/batch-features branch April 27, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants