-
Notifications
You must be signed in to change notification settings - Fork 68
[AL-2075] Batch list and export #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b06216
to
7dee8ef
Compare
@@ -23,3 +32,45 @@ class Batch(DbObject): | |||
# Relationships | |||
project = Relationship.ToOne("Project") | |||
created_by = Relationship.ToOne("User") | |||
|
|||
def export_data_rows(self, timeout_seconds=120) -> Generator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the same output structure as dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
LGTM to me but @msokoloff1 should give final sign off |
labelbox/schema/project.py
Outdated
cursor_path={ | ||
'project': None, | ||
'batches': None, | ||
'pageInfo': None, | ||
'endCursor': None | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think the type hint for PaginatedCollection is wrong. This can probably just be a list of the keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this looked wrong to me too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can also change the type hint from :
cursor_path: Optional[Dict[str, Any]] = None
to
cursor_path: Optional[List[str]] = None
That would be awesome
@@ -1,5 +1,14 @@ | |||
# Changelog | |||
|
|||
# Version 3.20.0 (2022-04-27) | |||
## Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is going to be a new version of the SDK, can we also include information on this merged PR?
Updated
NDJsonConverter
now supports Video bounding box annotations.- Note: Currently does not support nested classifications.
- Note: Converting an export into Labelbox annotation types, and back to export will result in only keyframe annotations. This is to support correct import format.
cc @msokoloff1 if this wording looks okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup looks good. Thanks
Adds
project.batches()
batch.export_data_rows()
(depends on intelligence pr #8171)Batch.project()
fixbatch.remove_queued_data_rows()