[AL-2384] Increase create_batch timeout #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtsodapop
reviewed
May 16, 2022
| res = self.client.execute(query_str, params, | ||
| res = self.client.execute(query_str, | ||
| params, | ||
| timeout=180.0, |
There was a problem hiding this comment.
Since this is change is only to accommodate project.create_batch, can we instead update the timeout for the specific method?
labelbox-python/labelbox/schema/project.py
Line 621 in 47063d7
res = self.client.execute(query_str, params, experimental=True, timeout=180)["project"][method]
There was a problem hiding this comment.
We're updating the timeout for this method only, am I missing something here?
There was a problem hiding this comment.
Oh, I was misreading the PR. Sorry about that, lgtm!
jtsodapop
approved these changes
May 16, 2022
| res = self.client.execute(query_str, params, | ||
| res = self.client.execute(query_str, | ||
| params, | ||
| timeout=180.0, |
There was a problem hiding this comment.
Oh, I was misreading the PR. Sorry about that, lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Increases
Project.create_batch()timeout, since for batch sizes > 10,000 thirty seconds usually isn't enough