Add model run config on create [AL-3060] #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hey, I don't have plenty of context on here, so would rather have someone else give a stamp / review |
|
Looks like the build is failing because your code is stale. It'll pass after you pull the latest changes |
…into mmw/create-model-run-with-config
| res = self.client.execute(query_str, { | ||
| name_param: name, | ||
| config_param: config, |
There was a problem hiding this comment.
Just curious, does this work okay when the param is None?
There was a problem hiding this comment.
Hm, let me test that
There was a problem hiding this comment.
While you're at it, could you add a test case for config being empty as well?
There was a problem hiding this comment.
yeah, thats what I meant! haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial metadata config on the model run when creating it