-
Notifications
You must be signed in to change notification settings - Fork 68
[AL-3329] Document Annotation Type for Export #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions around this:
- What's the difference between labelbox_v1 representations of annotations versus stuff inside
serialization/ndjson
? - Do we need a new rectangle object type specific to document? I don't see this pattern used for other data types, e.g. Video or Images
not sure if you receive an update when I make a reply, so re-tagging @kkim-labelbox !
i set this up this way since i thought it would make more sense to just re-use the LBV1Rectangle code as there are no required additional changes, but if it would make more sense to paste the same code in for this new class, i am open to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will update changelog once import side has also been complete! |
This PR is designed to:
page
andunit
extra
field when it exists, else it passes backNone
Rough example output: