Skip to content

count fp and tps correctly #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

count fp and tps correctly #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions labelbox/data/metrics/confusion_matrix/calculation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def feature_confusion_matrix(
Returns None if there are no annotations in ground_truth or prediction annotations
"""
if has_no_matching_annotations(ground_truths, predictions):
return [0, int(len(predictions) > 0), 0, int(len(ground_truths) > 0)]
return [0, len(predictions), 0, len(ground_truths)]
elif has_no_annotations(ground_truths, predictions):
return None
elif isinstance(predictions[0].value, Mask):
Expand Down Expand Up @@ -96,7 +96,7 @@ def classification_confusion_matrix(
"""

if has_no_matching_annotations(ground_truths, predictions):
return [0, int(len(predictions) > 0), 0, int(len(ground_truths) > 0)]
return [0, len(predictions), 0, len(ground_truths)]
elif has_no_annotations(
ground_truths,
predictions) or len(predictions) > 1 or len(ground_truths) > 1:
Expand Down Expand Up @@ -141,7 +141,7 @@ def vector_confusion_matrix(ground_truths: List[ObjectAnnotation],
Returns None if there are no annotations in ground_truth or prediction annotations
"""
if has_no_matching_annotations(ground_truths, predictions):
return [0, int(len(predictions) > 0), 0, int(len(ground_truths) > 0)]
return [0, len(predictions), 0, len(ground_truths)]
elif has_no_annotations(ground_truths, predictions):
return None

Expand Down Expand Up @@ -264,7 +264,7 @@ def mask_confusion_matrix(ground_truths: List[ObjectAnnotation],
confusion matrix as a list: [TP,FP,TN,FN]
"""
if has_no_matching_annotations(ground_truths, predictions):
return [0, int(len(predictions) > 0), 0, int(len(ground_truths) > 0)]
return [0, len(predictions), 0, len(ground_truths)]
elif has_no_annotations(ground_truths, predictions):
return None

Expand Down Expand Up @@ -306,7 +306,7 @@ def ner_confusion_matrix(ground_truths: List[ObjectAnnotation],
confusion matrix as a list: [TP,FP,TN,FN]
"""
if has_no_matching_annotations(ground_truths, predictions):
return [0, int(len(predictions) > 0), 0, int(len(ground_truths) > 0)]
return [0, len(predictions), 0, len(ground_truths)]
elif has_no_annotations(ground_truths, predictions):
return None
pairs = _get_ner_pairs(ground_truths, predictions)
Expand Down