[AL-0] SDK support for clear global keys #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labelbox/client.py
Outdated
| global_keys: List[str], | ||
| timeout_seconds=60) -> Dict[str, Union[str, List[Any]]]: | ||
| """ | ||
| Gets data row ids for a list of global keys. |
There was a problem hiding this comment.
Docstring should be updated
There was a problem hiding this comment.
yeah, I just copypasted for the format. We should work on an informative docstring.
labelbox/client.py
Outdated
| clear_global_keys_job["clearGlobalKeys"]["jobId"] | ||
| } | ||
|
|
||
| def _format_failed_rows(rows: List[str], |
There was a problem hiding this comment.
Nit: Could you define all helper functions right after the docstring?
kkim-labelbox
approved these changes
Nov 22, 2022
olegtrygub
force-pushed
the
AL-0/otrygub/clear_global_keys
branch
from
d64e3d0 to
9634b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.