[AL-0] Better error handling for label creation during test #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokoloff1
reviewed
Dec 22, 2022
| labels = project.label_generator() | ||
| label = next(labels) | ||
| assert label.data.media_attributes == {} | ||
| labels = project.label_generator().as_list() |
There was a problem hiding this comment.
you can also just call list(project.label_generator()). It makes it more readable.
There was a problem hiding this comment.
or even
labels = [project.label_generator().get_one()]
to be consistent with the other test
There was a problem hiding this comment.
ah, len([None]) == 1, forget my comment )
msokoloff1
reviewed
Dec 22, 2022
| labels = project.label_generator().as_list() | ||
| assert len( | ||
| labels | ||
| ) == 1, "Labels could not be fetched via `project.label_generator()`" |
There was a problem hiding this comment.
I am already imagining this error message being posted all over slack. This makes it seem like the problem is the sdk. I would say that label export job unexpectedly returned an empty result set.
There was a problem hiding this comment.
Thanks for the suggestions! Made the changes
msokoloff1
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two places where we were using a Generator to verify existence of the label, which was resulting in an error message that was hard to decipher