LibWeb: Implement anchor-size(..) function parsing
#5655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
force-pushed
the
libweb-anchor-size-parsing
branch
3 times, most recently
from
f70ce27 to
9ae335e
Compare
tcl3
reviewed
Jul 30, 2025
There was a problem hiding this comment.
Can we import the improved parsing tests. http://wpt.live/css/css-anchor-position/anchor-size-parse-valid.html runs reasonably quickly on my machine when imported.
If it's too slow can we at least import css/css-anchor-position/anchor-size-parse-invalid.html to prevent future regressions.
gmta
force-pushed
the
libweb-anchor-size-parsing
branch
from
9ae335e to
a642527
Compare
gmta
force-pushed
the
libweb-anchor-size-parsing
branch
from
a642527 to
3d9f605
Compare
tcl3
reviewed
Jul 30, 2025
gmta
force-pushed
the
libweb-anchor-size-parsing
branch
from
3d9f605 to
cfda8dc
Compare
This parses `anchor-size(..)` functions in CSS, but does not yet result in a useful `Size`: we need style & layout interleaving similar to container queries for this, since the resulting value depends on layout results. Not supported yet: `anchor-size()` appearing inside a `calc()` node. Adds 4280 WPT subtest passes in `css/css-anchor-position`.
gmta
force-pushed
the
libweb-anchor-size-parsing
branch
from
cfda8dc to
fdd0542
Compare
tcl3
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses
anchor-size(..)functions in CSS, but does not yet result in a usefulSize: we need style & layout interleaving similar to container queries for this, since the resulting value depends on layout results.Not supported yet:
anchor-size()appearing inside acalc()node.Adds 4280 WPT subtest passes in
css/css-anchor-position.