trigger ci #186
Merged
trigger ci #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odd... 3.7 failing but 3.8 is ok. |
|
Looks like the pandas version that is needed is not compatible with 3.7? Should maybe specify version in the pyproject.toml dependency section? |
|
I'm down to drop 3.7 support its quite ancient... what do you think? |
|
Its already past EOL: https://devguide.python.org/versions/ So if that is really the issue then i definitely think that it can be dropped. |
|
If this passes now i think we should also update the pyproject.toml to specify >=3.8 and maybe even the pandas version explicitely that was mentioned in the error message. (ah, right. This can actually pass atm...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.