Lexer & Parser #23
Merged
Lexer & Parser #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoWaster
force-pushed
the
lexer-parser
branch
4 times, most recently
from
d522802 to
6cf0081
Compare
WoWaster
force-pushed
the
lexer-parser
branch
from
356e688 to
d290a2e
Compare
gsvgit
reviewed
Sep 22, 2024
gsvgit
approved these changes
Sep 27, 2024
WoWaster
force-pushed
the
lexer-parser
branch
3 times, most recently
from
2ccc945 to
35eee8e
Compare
WoWaster
force-pushed
the
lexer-parser
branch
from
281300d to
83adf3d
Compare
gsvgit
reviewed
Oct 17, 2024
WoWaster
force-pushed
the
lexer-parser
branch
from
3756e7f to
fdd6fe3
Compare
gsvgit
reviewed
Oct 26, 2024
gsvgit
approved these changes
Oct 26, 2024
WoWaster
force-pushed
the
lexer-parser
branch
from
7bb1743 to
4d56a67
Compare
Lexer and LexerTypes make cyclic dependency. To solve this `.hs-boot` was required. And to minimize its content it was created for Lexer. IMO it would be great to move `instance MonadState AlexUserState Alex` to LexerTypes, but that would require ton of declarations in Lexer.hs-boot.
This commit is pretty messy, because I forgot to commit lexer changes separately from parser ones. This a reason why I can't squash TTG directly in lexer and parser commits. For more info about TTG look here: https://www.jucs.org/jucs_23_1/trees_that_grow/jucs_23_01_0042_0062_najd.pdf
It helps with type check in presence of type level programming. Also it is included in GHC2024, so IMO it can be considered safe.
Also some Hedgehog tests for LML ppr
WoWaster
force-pushed
the
lexer-parser
branch
from
4d56a67 to
6554bdd
Compare
|
I squashed ton of commits here. But history is still quite dirty, because silly me forgot to commit lexer changes separately from parser ones while I was doing TTG rewrite 😢 |
KubEF
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.