Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/smartui-cli",
"version": "4.1.19",
"version": "4.1.20",
"description": "A command line interface (CLI) to run SmartUI tests on LambdaTest",
"files": [
"dist/**/*"
Expand Down
8 changes: 5 additions & 3 deletions src/lib/ctx.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Context, Env, WebConfig, MobileConfig, basicAuth, tunnelConfig } from '../types.js'
import constants from './constants.js'
import { version } from '../../package.json'
import { validateConfig } from './schemaValidation.js'
import { validateConfig, validateConfigForScheduled } from './schemaValidation.js'
import logger from './logger.js'
import getEnv from './env.js'
import httpClient from './httpClient.js'
Expand Down Expand Up @@ -36,9 +36,11 @@ export default (options: Record<string, string>): Context => {
delete config.web.resolutions;
}

let validateConfigFn = options.scheduled ? validateConfigForScheduled : validateConfig;

// validate config
if (!validateConfig(config)) {
throw new Error(validateConfig.errors[0].message);
if (!validateConfigFn(config)) {
throw new Error(validateConfigFn.errors[0].message);
}
} else {
logger.info("## No config file provided. Using default config.");
Expand Down
39 changes: 38 additions & 1 deletion src/lib/schemaValidation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -763,4 +763,41 @@ export const validateWebStaticConfig = ajv.compile(WebStaticConfigSchema);
export const validateSnapshot = ajv.compile(SnapshotSchema);
export const validateFigmaDesignConfig = ajv.compile(FigmaDesignConfigSchema);
export const validateWebFigmaConfig = ajv.compile(FigmaWebConfigSchema);
export const validateAppFigmaConfig = ajv.compile(FigmaAppConfigSchema);
export const validateAppFigmaConfig = ajv.compile(FigmaAppConfigSchema);

export const validateConfigForScheduled = (config: any) => {
validateConfigForScheduled.errors = null;


if (!validateConfig(config)) {

let errors = validateConfig.errors || [];

errors = errors.filter(error => {
const message = error.message || '';
return !message.includes('max unique viewports allowed - 5')
});

if (config.web && config.web.viewports && Array.isArray(config.web.viewports)) {
if (config.web.viewports.length > 8) {
errors.push({
message: "Invalid config; max unique viewports allowed - 8 (scheduled build)",
keyword: "maxItems",
instancePath: "/web/viewports",
schemaPath: "#/properties/web/properties/viewports/maxItems"
} as any);
}
}

// If there are any errors remaining, set them and return false
if (errors.length > 0) {
validateConfigForScheduled.errors = errors;
return false;
}
}

return true;
};

// Initialize the errors property
validateConfigForScheduled.errors = null;