Skip to content

skip smartui logs file in exec:stop API #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

skip smartui logs file in exec:stop API #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e7e670
Merge pull request #339 from LambdaTest/stage
sushobhit-lt Aug 28, 2025
8c2ad3d
skip smartui logs file in exec:stop API
sushobhit-lt Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/smartui-cli",
"version": "4.1.26",
"version": "4.1.27",
"description": "A command line interface (CLI) to run SmartUI tests on LambdaTest",
"files": [
"dist/**/*"
Expand Down
5 changes: 3 additions & 2 deletions src/lib/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,9 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
let resp = await ctx.client.getS3PreSignedURL(ctx);
await ctx.client.uploadLogs(ctx, resp.data.url);
} else {
ctx.log.debug(`Log file to be uploaded via LSRS`)
let resp = ctx.client.sendCliLogsToLSRS(ctx);
ctx.log.debug(`Skipping upload of CLI logs as useLambdaInternal is set`)
// ctx.log.debug(`Log file to be uploaded via LSRS`)
// let resp = ctx.client.sendCliLogsToLSRS(ctx);
}

if (pingIntervalId !== null) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/snapshotQueue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export default class Queue {

if (!this.ctx.config.delayedUpload && snapshot && snapshot.name && this.snapshotNames.includes(snapshot.name) && !this.ctx.config.allowDuplicateSnapshotNames) {
drop = true;
this.ctx.log.info(`Skipping duplicate SmartUI snapshot '${snapshot.name}'. To capture duplicate screenshots, please set the 'delayedUpload' configuration as true in your config file.`);
this.ctx.log.info(`Skipping duplicate SmartUI snapshot '${snapshot.name}'. To capture duplicate screenshots, please set the 'allowDuplicateSnapshotNames' or 'delayedUpload' configuration as true in your config file.`);
}

if (this.ctx.config.delayedUpload && snapshot && snapshot.name && this.snapshotNames.includes(snapshot.name)) {
Expand Down