Skip to content

Conversation

sushobhit-lt
Copy link
Collaborator

This pull request introduces several enhancements and bug fixes across the SmartUI CLI codebase, with a focus on configuration validation, tunnel management, error handling, and snapshot processing. The most significant changes include stricter validation and usage of approval/rejection thresholds, improved tunnel lifecycle management, and better error reporting. These updates aim to make the CLI more robust and easier to debug, while supporting new configuration options.

Configuration validation and usage

  • Added validation to ensure that rejectionThreshold is greater than approvalThreshold in both config and snapshot options, and passed these values through the context and snapshot processing pipeline. [1] [2] [3] [4] [5] [6]
  • Updated schema validation to support approvalThreshold and rejectionThreshold in both config and snapshot options, including type and range checks. [1] [2]

Tunnel management improvements

  • Enhanced tunnel lifecycle by starting tunnels automatically when required, polling for tunnel status during build finalization, and ensuring tunnels are properly stopped after execution. [1] [2] [3] [4]

Error handling and reporting

  • Improved error handling for server stop scenarios, including specific messages for connection errors and ensuring the process exits on fatal errors. [1] [2]
  • Added more detailed logging during build finalization and server teardown for better traceability. [1] [2] [3]

API and method signature updates

  • Updated several method signatures to pass additional parameters such as buildName, isStartExec, and threshold values, supporting new features and improved context awareness. [1] [2] [3] [4]

Dependency and configuration changes

  • Added an override for the simple-swizzle dependency in package.json and introduced support for an environment config property with validation. [1] [2]

These changes collectively improve the reliability, configurability, and maintainability of the SmartUI CLI.

Nick-1234531 and others added 28 commits September 10, 2025 14:15
overrides simple-swizzle version to 0.2.2
auto tunnel support added in exec:start
DOT-6242: Add support for extended viewport and DOM content loading
Screenshot and build level threshold
handle tunnel cases with exec:start
@parthlambdatest parthlambdatest merged commit c7f095e into prod Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants