fix: bls sig operator state retriever sorting #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or ids are ascending
RonTuretzky
changed the title
ypatil12
reviewed
May 16, 2025
| import {StorageSlot} from "@openzeppelin/contracts/utils/StorageSlot.sol"; | ||
| import {Math} from "@openzeppelin/contracts/utils/math/Math.sol"; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Nit: can we add a comment why we're copy-pasting these (due to not being on v5.1 OZ). Another option is to add another submodule
There was a problem hiding this comment.
addressed with 85ed41d
|
|
ypatil12
approved these changes
May 16, 2025
ypatil12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Non-signer pubkeys were not properly ordered in the last iteration of this feature
Modifications:
Added OZ libraries as packed utilities for sorting, added sorting of the non-signers before returning them
Result:
Now all parameters returned are sorted in ascending order, which allows for strong assurances regarding non-duplicates in the array