Allow multiple features per ID per tile #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traustid
approved these changes
Dec 6, 2017
|
This fix solved my problem as well, this should be reviewed and added to future release. |
|
This is ready for re-review (conflicts against |
revatim
approved these changes
Jul 26, 2019
revatim
approved these changes
Jul 26, 2019
IvanSanchez
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #65, I was running into a case where only some features were getting updated with
setFeatureStyleandresetFeatureStyle.The underlying reason is addressed in this PR: there are multiple features that have the same ID in a given tile, but only the last encountered was stored with that ID (in
renderer._features[id]).I changed this to allow an array instead of a single feature and updated
setFeatureStyleandresetFeatureStyleto use this. It fixed my particular case.(not sure what is going on here with whitespace, it looks right in my editor. Sorry for any formatting issues)