Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Shiki twoslash error displays are visually offset slightly #117

Closed
2 tasks done
JoshuaKGoldberg opened this issue Oct 31, 2023 · 0 comments · Fixed by #122
Closed
2 tasks done

🐛 Bug: Shiki twoslash error displays are visually offset slightly #117

JoshuaKGoldberg opened this issue Oct 31, 2023 · 0 comments · Fixed by #122
Labels
accepting prs type: bug Something isn't working

Comments

@JoshuaKGoldberg
Copy link
Collaborator

Bug Report Checklist

  • I have searched for related issues and found none that matched my issue.
  • This is the appropriate issue form for the bug I would like to report.

Expected

Don't have visual bugs 😄? There should be no text overflow around code snippets or shiki error annotations.

Actual

#116

Screenshot of a codeblock with a shiki twoslash error annotation. The code in the annotation has overflowed past its allowed area.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working accepting prs labels Oct 31, 2023
StyleShit added a commit to StyleShit/learning-typescript-site that referenced this issue Dec 12, 2023
@StyleShit
fix: Shiki twoslash error displays are visually offset slightly
a00dfbc 
Closes LearningTypeScript#117
@StyleShit StyleShit mentioned this issue Dec 12, 2023
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Dec 12, 2023
@StyleShit
fix: Shiki twoslash error displays are visually offset slightly (#122)
c223740 
* fix: Shiki twoslash error displays are visually offset slightly

Closes #117

* remove redundant fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Shiki twoslash error displays are visually offset slightly StyleShit/learning-typescript-site
1 participant
@JoshuaKGoldberg