Support multiple versions of Kubernetes #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish the model as part of the client interface. That way the client can determine which model is suitable for interacting with the designated Kubernetes API server.
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 98.16% 97.86% -0.31%
==========================================
Files 25 25
Lines 2122 2245 +123
Branches 201 210 +9
==========================================
+ Hits 2083 2197 +114
- Misses 26 33 +7
- Partials 13 15 +2
Continue to review full report at Codecov.
|
wallrj
reviewed
May 24, 2017
src/txkube/_network.py
Outdated
| _versions = { | ||
| (u"1", u"5"): v1_5_model, | ||
| (u"1", u"6"): v1_6_model, | ||
| (u"1", u"7"): v1_7_model, |
There was a problem hiding this comment.
In LeastAuthority/kubetop#44 I tried testing kubetop against minikube start --kubernetes-version v1.7.0-alpha.2.
It gave this error:
(kubetop) [richard@drax txkube]$ kubetop
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#1, [Failure instance: Traceback: <type 'exceptions.ValueError'>: Unsupported Kubernetes version: .
The version.Info in this case looked like this:
version.Info(major=u'', gitTreeState=u'not a git tree', buildDate=u'1970-01-01T00:00:00Z', platform=u'linux/amd64', gitVersion=u'v0.0.0-master+$Format:%h$', gitCommit=u'$Format:%H$', compiler=u'gc', minor=u'', goVersion=u'go1.7.3')
wallrj
reviewed
May 24, 2017
src/txkube/_network.py
Outdated
| model = self._versions[version.major, version.minor] | ||
| except KeyError: | ||
| raise ValueError( | ||
| "Unsupported Kubernetes version: {}.{}".format( |
There was a problem hiding this comment.
❓ It would have been clearer if the exception had included the full version.Info repr.
|
To be replaced by a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121