Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump stellar-sdk from 10.4.1 to 11.3.0. #6497

Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore(deps): Bump stellar-sdk from 10.4.1 to 11.3.0. #6497

merged 1 commit into from
Mar 28, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Mar 21, 2024 •
edited
Loading

📝 Description

In #6189, we encountered a bug on LLM and then rolled it back. This PR fixes the issue.

The code in this PR is identical to #6189, except that I changed the stellar-sdk version from 11.2.2 to 11.3.0.

cc @hedi-edelbloute

❓ Context

N/A

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@overcat overcat requested a review from a team as a code owner March 21, 2024 02:02
@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Mar 28, 2024 6:55am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 6:55am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 6:55am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 6:55am

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024

@overcat is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs fork Pull request base branch comes from a fork. labels Mar 21, 2024
@overcat overcat marked this pull request as draft March 21, 2024 03:14
@socket-security Socket Security
Copy link

socket-security bot commented Mar 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@overcat
Copy link
Contributor Author

overcat commented Mar 21, 2024 •
edited by live-github-bot bot
Loading

@overcat

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@overcat overcat marked this pull request as ready for review March 21, 2024 08:25
@hedi-edelbloute hedi-edelbloute merged commit 5ef111e into LedgerHQ:develop Mar 28, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

Assignees

@overcat overcat

Labels
common Has changes in live-common fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overcat @hedi-edelbloute