Retry webhook emission if failure

.travis.yml

@@ -4,6 +4,7 @@ addons:
   postgresql: "9.6"
 services:
   - postgresql
+  - redis-server
 sudo: false
 language: ruby
 cache: bundler

app/controllers/application_controller.rb

@@ -3,6 +3,12 @@ class ApplicationController < ActionController::Base
 
   private
 
+  def development_enabled?
+    Util::DevelopmentHelper.development_enabled?
+  end
+
+  helper_method :development_enabled?
+
   def raise_404(message: nil)
     raise ActionController::RoutingError, (message || 'Not Found')
   end

app/controllers/auth_tokens_controller.rb

@@ -8,7 +8,7 @@ def destroy
   end
 
   def dev_login
-    raise_404 unless Rails.env.development?
+    raise_404 unless development_enabled?
 
     warden.logout
     authenticate!(:developer)

app/controllers/dev/base_controller.rb

@@ -7,7 +7,9 @@ class BaseController < UIController
     private
 
     def ensure_development
-      raise_404 unless Rails.env.development?
+      return if development_enabled?
+
+      raise_404
     end
   end
-end
+end

app/controllers/ledgers/test_controller.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Ledgers
+  class TestController < DashboardBaseController
+    before_action :ensure_test_env
+    before_action :set_ledger, only: %i[show]
+
+    private
+
+    def ensure_test_env
+      return if Rails.env.test?
+
+      raise_404
+    end
+
+    def set_ledger
+      @ledger = current_organization
+                .ledgers(kind: LedgerSync.adaptors.test.root_key.to_s)
+                .object
+                .find(params[:id])
+                .decorate
+    end
+  end
+end

app/controllers/ledgers_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class LedgersController < DashboardBaseController
   before_action :set_ledger, only: :show
 
@@ -10,4 +12,4 @@ def show
   def set_ledger
     @ledger = Ledger.find(params[:id]).decorate
   end
-end
+end

app/decorators/ledger_decorator.rb

@@ -12,9 +12,12 @@ def name
   end
 
   def show_path
-    case kind
+    case kind.to_s
     when Util::QuickBooksOnline::KEY
       r.ledgers_quickbooks_online_path(self)
+    when LedgerSync.adaptors.test.root_key.to_s
+      raise NotImplementedError unless Rails.env.test?
+      r.ledgers_test_path(self)
     else
       raise NotImplementedError
     end

app/jobs/event_jobs.rb

@@ -18,8 +18,10 @@ def perform(data, event_object_type, event_object_id, organization_id, type)
 
   class Emit < ApplicationJob
     def perform(event_id)
+      event = Event.find(event_id)
+
       Forms::Events::Emit.new(
-        event: Event.find(event_id)
+        event: event
       ).save.raise_if_error
     end
   end

app/lib/forms/events/emit.rb

@@ -38,9 +38,22 @@ def emit
         response = HTTP.headers(headers).post(url, body: serialized_event_json_string)
         status = response.status
 
-        return failure(status.inspect) unless status.success?
+        return success(event) if status.success?
 
-        success(event)
+        notify_provider
+        failure(status.inspect)
+      end
+
+      def notify_provider
+        redis = Redis.new
+        key = 'webhooks/provider_last_notified_at'
+
+        provider_last_notified_at = redis.get(key)
+
+        return if provider_last_notified_at.present? && (Time.zone.now - Time.parse(provider_last_notified_at)) < 24.hours
+
+        redis.set(key, Time.zone.now.to_s)
+        DeveloperMailer.webhook_failure(event.id).deliver_later
       end
 
       def serialized_event_json_string

app/lib/util/development_helper.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Util
+  module DevelopmentHelper
+    def self.development_enabled?
+      Rails.env.development? || (Rails.env.test? && ENV['DEVELOPMENT'] == 'true')
+    end
+  end
+end

app/mailers/application_mailer.rb

@@ -1,4 +1,4 @@
 class ApplicationMailer < ActionMailer::Base
-  default from: 'from@example.com'
+  default from: Settings.mailer.from_email
   layout 'mailer'
 end

app/mailers/developer_mailer.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class DeveloperMailer < ApplicationMailer
+  def webhook_failure(event_id)
+    @event = Event.find(event_id)
+    mail(
+      subject: "Webhook failure at #{Time.zone.now}",
+      to: Settings.application.developer_email
+    )
+  end
+end

app/views/developer_mailer/webhook_failure.html.haml

@@ -0,0 +1,4 @@
+%h1 Webhook Failure
+
+%p
+  Event ID: #{@event.id}

app/views/layouts/_nav.html.haml

@@ -25,7 +25,8 @@
       %li.nav-item.mr-3
         = link_to '#', class: 'nav-link' do
           Log In
-      - if Rails.env.development?
-        %li.nav-item.mr-3
-          = link_to dev_login_path, class: 'btn btn-danger' do
-            Dev Log In
+- if development_enabled?
+  %ul
+    %li.nav-item.mr-3
+      = link_to dev_login_path, class: 'btn btn-danger' do
+        Dev Log In

app/views/layouts/mailer.html.haml

@@ -0,0 +1,8 @@
+!!!
+%html
+  %head
+    %meta{:content => "text/html; charset=utf-8", "http-equiv" => "Content-Type"}/
+    :css
+      /* Email styles need to be inline */
+  %body
+    = yield

app/views/ledgers/test/show.html.haml

@@ -0,0 +1,2 @@
+.container
+  %h1 Test Adaptor - You made it!

config/initializers/config.rb

@@ -79,6 +79,7 @@
     end
 
     required(:application).schema do
+      required(:developer_email).filled(:str?)
       required(:host_port).maybe(:int?)
       required(:host_url).filled(:str?)
       required(:login_url).maybe(:str?)
@@ -102,6 +103,7 @@
     required(:mailer).filled do
       schema do
         required(:delivery_method).filled(:str?)
+        required(:from_email).filled(:str?)
         optional(:smtp).filled do
           schema do
             required(:address).filled(:str?)

config/initializers/warden.rb

@@ -18,7 +18,7 @@ def result
 
 Warden::Strategies.add(:developer) do
   def valid?
-    raise 'Invalid strategy' unless Rails.env.development?
+    raise 'Invalid strategy' unless Util::DevelopmentHelper.development_enabled?
 
     true
   end

config/routes.rb

@@ -98,6 +98,7 @@
     resources :ledgers, only: %i[index show]
 
     namespace :ledgers do
+      resources :tests, path: :test, only: %i[show], controller: :test
       resources :quickbooks_onlines, path: :quickbooks_online, only: %i[destroy new show update], controller: :quickbooks_online do
         collection do
           get :callback

config/settings.yml

@@ -20,9 +20,10 @@ api:
   root_secret_key:                  # required: The API key your application will use to send data to the Ledger Sync App
 
 application:
-  login_url:                        # required: the url where users will be redirect if authentication is required
+  developer_email:                  # required: email for developer notifications (e.g. webhook failure)
   host_port:                        # optional
   host_url:                         # required: where this app is hosted (e.g. `sync.example.com`)
+  login_url:                        # required: the url where users will be redirect if authentication is required
   name: 'Ledger Sync'               # required: usually your company name
   theme: modern_treasury            # optional: Name of theme in app/assets/stylesheets/themes
   webhooks:
@@ -39,6 +40,7 @@ customization:
 mailer:
   delivery_method:                  # required: letter_opener (only in development), smtp, test (only in test)
   disable_email_to_users: false     # optional
+  from_email:                       # required: email address for replies
   # smtp:                           # required if delivery_method=smtp
   #   address:                      # - required
   #   authentication:               # - required

config/settings/development.yml

@@ -1,4 +1,5 @@
 application:
+  developer_email: me@example.com
   host_url: 'localhost'
   host_port: 3000
 
@@ -7,3 +8,4 @@ dev:
 
 mailer:
   delivery_method: 'letter_opener'
+  from_email: 'no-reply-dev@example.com'

config/settings/test.yml

@@ -9,10 +9,12 @@ add_ons:
 api:
   root_secret_key: 'test_api_key'
 application:
+  developer_email: test@example.com
   host_url: 'lvh.me'
   host_port: 3000
   webhooks:
     key: 'foobarbaz'
-    url: 'http://lvh.me'
+    url: 'http://127.0.0.1:3000'
 mailer:
-  delivery_method: 'test'
+  delivery_method: 'test'
+  from_email: 'no-reply-test@example.com'

spec/decorators/ledger_decorator_spec.rb

@@ -13,6 +13,11 @@
 
     it do
       ledger = create(:ledger, :test)
+      expect(ledger.decorate.show_path).to eq(r.ledgers_test_path(ledger))
+    end
+
+    it do
+      ledger = create(:ledger, kind: :asdf)
       expect { ledger.decorate.show_path }.to raise_error(NotImplementedError)
     end
   end

spec/features/dev/authentication_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+require 'formify/spec_helpers'
+
+describe 'dev/authentication', js: true, type: :feature do
+  def expect_authorized
+    expect_content('authorized')
+  end
+
+  def expect_unauthorized
+    expect_content('unauthorized')
+  end
+
+  it do
+    visit r.root_path
+    expect_no_content :invisible, 'Dev Log In'
+    visit r.auth_tokens_path
+    expect_unauthorized
+  end
+
+  it do
+    ClimateControl.modify(DEVELOPMENT: 'true') do
+      visit r.root_path
+      click_on 'Dev Log In'
+      visit r.auth_tokens_path
+      expect_authorized
+    end
+  end
+end

spec/features/dev/home_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+require 'formify/spec_helpers'
+
+describe 'dev/home', js: true, type: :feature do
+  it do
+    ClimateControl.modify(DEVELOPMENT: 'true') do
+      visit r.root_path
+      click_on 'Dev Log In'
+      visit r.dev_path
+      expect_content 'Create Sync'
+    end
+  end
+end

spec/features/dev/syncs_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe 'sync_ledgers/create', js: true, type: :feature do
+  xit do
+    login
+    expect { visit r.new_dev_sync_path }.to raise_error(ActionController::RoutingError)
+  end
+
+  it do
+    ClimateControl.modify(DEVELOPMENT: 'true') do
+      login(FactoryBot.create(:user, :admin))
+      visit r.new_dev_sync_path
+      expect_content 'Create Sync'
+      expect do
+        click_on 'Send'
+        expect_content 'Operation'
+      end.to change(Sync, :count).from(0).to(1)
+    end
+  end
+end