Add trade penalty #703
Closed
Add trade penalty #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing target value.
…st move_count to be more correct
Add trade penalty to 20.1
Also temporarily disable best_child_cached_.
Also add some more params to control things.
Also increase hash size to 1024MB.
Also handle root node.
Also cleanup some log messages.
AuxEngineOptions is now "optname1=value1;optname2=value2" format. Change default AuxEngineDepth from 20 to 15. Make version v0.21.0-fish-v0.2
Default 3, setting to 1 will give v0.2 behavior. Store move that was boosted. Note two magic values are used to store extra state, TODO improve this. Fix bug that caused castling to not be boosted by using move packed_int instead of nn_index. Move node.auxengine_move_ member to the proper spot, now Node size is still 80 bytes. Move auxengine intialization into AuxEngineWorker, so init time does not slow down startup.
Compressed format does not allow this. Also set maximum AuxEngineBoost to 100.
Auto detects if AuxEngine has the SyzygyPath UCI option, and auto sets it to the same value given to Lc0 engine.
Update initial params and force a new appveyor build to boot :)
force another compile
|
As trade penalty is non-zero and the possible advantages of this are available through a combination of MLH and draw score which are both merged in v0.25, I recommend closing this PR. |
|
Moreover there seems to have been a bad merge at some point, there are lots of code unrelated to trade penalty here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add trade penalty to lc0 20.1