Skip to content

fix(di): should get instance by token if @Inject param decorator used #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

fix(di): should get instance by token if @Inject param decorator used #62

merged 1 commit into from
Nov 21, 2019

Conversation

forehalo
Copy link
Contributor

fix #61

@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #62 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   95.05%   95.12%   +0.06%     
==========================================
  Files          29       29              
  Lines         526      533       +7     
  Branches       80       84       +4     
==========================================
+ Hits          500      507       +7     
  Misses         26       26
Impacted Files Coverage Δ
src/core/scope/utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c601a84...cc378cd. Read the comment docs.

Brooooooklyn
Brooooooklyn approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@Brooooooklyn Brooooooklyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
687474703a2f2f6a756e6b796172642e64616d6f776d6f772e636f6d2f353737

@Brooooooklyn Brooooooklyn merged commit 330825a into master Nov 21, 2019
@Brooooooklyn Brooooooklyn deleted the fix/di branch November 21, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No provider for Object
2 participants
@forehalo @Brooooooklyn