Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top voted solution webview #193

Merged
merged 15 commits into from Mar 13, 2019
Merged

Top voted solution webview #193

merged 15 commits into from Mar 13, 2019

Conversation

Vigilans
Copy link
Contributor

@Vigilans Vigilans commented Mar 8, 2019

Introduction

Solves #96
This PR is independent with #188.

Details

  • indented code block uses solution language to highlight.
  • uses built-in markdown extension to provide style files.

Demonstration

image

image

References

@jdneo jdneo self-requested a review March 11, 2019 01:47
@jdneo jdneo added this to the 0.13.0 milestone Mar 11, 2019
@jdneo
Copy link
Member

jdneo commented Mar 11, 2019

@Vigilans Sorry for the conflict made by merging another PR, would you mind to resolve it?

@Vigilans
Copy link
Contributor Author

@jdneo Conflict has been resolved.

@jdneo
Copy link
Member

jdneo commented Mar 11, 2019

Cool, I'll take a look tonight

jdneo
jdneo reviewed Mar 11, 2019
View reviewed changes
src/leetCodeExecutor.ts Outdated Show resolved Hide resolved
jdneo
jdneo reviewed Mar 11, 2019
View reviewed changes
src/shared.ts Outdated Show resolved Hide resolved
jdneo
jdneo reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool feature! Just some comments for small changes.

jdneo
jdneo reviewed Mar 13, 2019
View reviewed changes
src/leetCodeExecutor.ts Outdated Show resolved Hide resolved
jdneo
jdneo reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, still cannot get style work on my Mac...

@jdneo
Copy link
Member

jdneo commented Mar 13, 2019

@Vigilans Thank you for keep working on this PR, it's very near to get merged.

Vigilans and others added 2 commits March 13, 2019 16:59
@Vigilans
Minor fixes according to review
c033f24 
* Revert plugin modification
* Move markdown style error prompt from dialog to channel
@jdneo
Merge branch 'master' into solution-view
3f7a90d
jdneo
jdneo approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. This feature will significantly increase the user experience. And we can adopt the same render logic into the result provider and preview provider.

@jdneo jdneo merged commit 9b33df0 into LeetCode-OpenSource:master Mar 13, 2019
This was referenced Mar 13, 2019
Open
Closed
@Vigilans Vigilans deleted the solution-view branch March 20, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vigilans @jdneo