Skip to content

Can config whether to show or hide the codelens #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2019
Merged

Can config whether to show or hide the codelens #273

merged 1 commit into from
Apr 17, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Apr 16, 2019

Resolve: #146

@jdneo jdneo added this to the 0.13.4 milestone Apr 16, 2019
@jdneo jdneo requested review from poppinlp and Vigilans April 16, 2019 12:42
@Vigilans
Copy link
Contributor

#269

Also, add a solution button to codelens?

@jdneo
Copy link
Member Author

jdneo commented Apr 16, 2019

Good idea. I'll do it in another PR.

Vigilans
Vigilans approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the future, I planned to use codelens to show the number of submissions of current problem, and when clicking it, user could peek submission codes, which are divided into categories like Accepted and Failed.

@jdneo jdneo merged commit b77d76a into master Apr 17, 2019
@jdneo jdneo deleted the cs/codelens branch April 17, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppinlp poppinlp Awaiting requested review from poppinlp

1 more reviewer

@Vigilans Vigilans Vigilans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

could provide an option to hide the Submit to LeetCode button in the editor?
2 participants
@jdneo @Vigilans