Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showCommentDescription config #289

Merged
merged 3 commits into from
Apr 27, 2019
Merged

Add showCommentDescription config #289

merged 3 commits into from
Apr 27, 2019

Conversation

Vigilans
Copy link
Contributor

@Vigilans Vigilans commented Apr 23, 2019 •
edited
Loading

Defaults to false.

Relies on leetcode-tools/leetcode-cli#11

Solves #287

Demo:
demo2

@Vigilans Vigilans requested a review from jdneo April 23, 2019 11:03
@Vigilans Vigilans mentioned this pull request Apr 27, 2019
Closed
jdneo
jdneo reviewed Apr 27, 2019
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some small things.

package.json Outdated Show resolved Hide resolved
src/leetCodeExecutor.ts Outdated Show resolved Hide resolved
@jdneo
Copy link
Member

jdneo commented Apr 27, 2019

@Vigilans 2.6.5 has been released. Please update the dependency as well. Thanks.

@jdneo jdneo added this to the 0.14.1 milestone Apr 27, 2019
@jdneo jdneo merged commit 0109197 into LeetCode-OpenSource:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vigilans @jdneo